chore: remove unnecessary .unwrap() calls - #256
Merged
Merged
Conversation
github-actions
Bot
added
the
t-tooling
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary .unwrap() calls throughout the Impit codebase to prevent potential runtime panics and improve error handling. The changes replace risky unwrap calls with safer alternatives like fallback values, proper error propagation, and explicit error handling.
- Replaces
.unwrap()calls with safer alternatives like.unwrap_or_default()and explicit match statements - Improves error handling by returning proper error types instead of panicking
- Updates function signatures to return
Resulttypes where appropriate for better error propagation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| impit/src/impit.rs | Replaces unwrap calls with match statements and fallback values for URL parsing and HTTP3 engine handling |
| impit-python/src/cookies.rs | Converts unwrap calls to unwrap_or_default and changes function signature to return PyResult |
| impit-python/src/client.rs | Updates cookie jar initialization to properly handle errors from the changed function signature |
| impit-python/src/async_client.rs | Updates async cookie jar initialization with proper error propagation |
| impit-node/src/response.rs | Replaces unwrap with explicit error handling for response property access |
| impit-node/src/request.rs | Improves error handling in async operations and removes unwrap from threadsafe function building |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers the risk of rogue
panics by removing the unnecessary (and potentially dangerous).unwrap()calls in Impit codebase.